Attachments in compose and reply #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the two introductory pages, “Introduction” & “Get Started” and their controllers/design. Fixed the flow to redirect to the first page when setting up, and from them to the Welcome page.
Added the case in which the user is Logged in but does not have authorizations. Fixed the flow accordingly. Fixed the design of the rest.
| @@ -457,9 +457,12 @@ ThreadsCtrl.prototype.isInviteInProgress = function() { | |||
|
|
|||
|
|
|||
| /** | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
This and the above are file conflict markers, you should resolve the conflicts by deleting the lines in those files that shouldn't be there (<<<<, ==== and >>> lines should not be committed).
| .email-detail-from { | ||
|
|
||
| .email-detail-from { | ||
| text-align: left !important; |
There was a problem hiding this comment.
text-align: left shouldn't be needed as the text-align: center was fixed in e19e0e3.
added 5 commits
August 17, 2016 16:44
…' of https://github.com/KamilaHasanbega/e2email into show-attachments
…/e2email into show-attachments
| }; | ||
|
|
||
|
|
||
| /** |
There was a problem hiding this comment.
The function description is missing, same below.
| goog.provide('e2email.models.mail.Mail'); | ||
| goog.provide('e2email.models.mail.Mailbox'); | ||
| goog.provide('e2email.models.mail.Thread'); | ||
|
|
||
|
|
||
| /** | ||
| * This is the model for the attachments support. | ||
| * The filename is the attachment's name, size is it's size in Bytes, |
There was a problem hiding this comment.
some typos: Bytes -> bytes and the ocntent.
There was a problem hiding this comment.
it's size => its size, same for content
| * size: number | ||
| * }} | ||
| */ | ||
| e2email.models.mail.Attachments; |
There was a problem hiding this comment.
This should be singular, as it defines a single attachment.
|
LGTM, safe to merge. |
|
Rebased via 86185ae |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the page for replying with attachments, and added tests for the new onFileUpload function. Fixed other tests to include attachments.