Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/api/internal/handlers/sandboxes_list.go
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,10 @@ func convertFromDBMountsToAPIMounts(mounts []*dbtypes.SandboxVolumeMountConfig)
results := make([]api.SandboxVolumeMount, 0, len(mounts))

for _, item := range mounts {
if item == nil {
continue
}

results = append(results, api.SandboxVolumeMount{
Name: item.Name,
Path: item.Path,
Expand Down
46 changes: 46 additions & 0 deletions packages/api/internal/handlers/volume_util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"github.com/e2b-dev/infra/packages/api/internal/orchestrator/nodemanager"
"github.com/e2b-dev/infra/packages/auth/pkg/types"
authqueries "github.com/e2b-dev/infra/packages/db/pkg/auth/queries"
dbtypes "github.com/e2b-dev/infra/packages/db/pkg/types"
)

func TestVolumeTokenAudience(t *testing.T) {
Expand Down Expand Up @@ -151,3 +152,48 @@ func TestFindNodesByVolumeLabel(t *testing.T) {
})
}
}

func TestConvertFromDBMountsToAPIMounts(t *testing.T) {
t.Parallel()

t.Run("converts valid mounts", func(t *testing.T) {
t.Parallel()

mounts := []*dbtypes.SandboxVolumeMountConfig{
{Name: "v1", Path: "/mnt/data1"},
{Name: "v2", Path: "/mnt/data2"},
}

res := convertFromDBMountsToAPIMounts(mounts)
assert.NotNil(t, res)
assert.Len(t, *res, 2)
assert.Equal(t, "v1", (*res)[0].Name)
assert.Equal(t, "/mnt/data1", (*res)[0].Path)
assert.Equal(t, "v2", (*res)[1].Name)
assert.Equal(t, "/mnt/data2", (*res)[1].Path)
})

t.Run("skips nil items safely without panic", func(t *testing.T) {
t.Parallel()

mounts := []*dbtypes.SandboxVolumeMountConfig{
{Name: "v1", Path: "/mnt/data1"},
nil,
{Name: "v2", Path: "/mnt/data2"},
}

res := convertFromDBMountsToAPIMounts(mounts)
assert.NotNil(t, res)
assert.Len(t, *res, 2)
assert.Equal(t, "v1", (*res)[0].Name)
assert.Equal(t, "v2", (*res)[1].Name)
})

t.Run("empty input returns non-nil pointer to empty slice", func(t *testing.T) {
t.Parallel()

res := convertFromDBMountsToAPIMounts(nil)
assert.NotNil(t, res)
assert.Empty(t, *res)
})
}