-
Notifications
You must be signed in to change notification settings - Fork 207
Tweak bot PR review prompts #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Forbidden Action: Permission Mismatch
The workflow instructs Claude to post inline comments using gh api to create PR review comments, but the permissions block only grants pull-requests: read. Posting comments via the GitHub API requires pull-requests: write permission, causing the workflow to fail with a 403 Forbidden error when attempting to post comments.
.github/workflows/claude-code-review.yml#L11-L16
infra/.github/workflows/claude-code-review.yml
Lines 11 to 16 in c919c3a
| runs-on: ubuntu-latest | |
| permissions: | |
| contents: read | |
| pull-requests: read | |
| issues: read | |
| id-token: write |
Previously, it was able to post normal comments with these permissions, so I think the permissions are granted by the Claude GH App. |
|
Can we merge this soon, claude is suuuuuper annoying |
| on: | ||
| pull_request: | ||
| types: [opened, synchronize] | ||
| types: [opened] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: API Comments: Permissions Denied
The workflow instructs Claude to post inline PR comments using gh api to create review comments, but the permissions only grant pull-requests: read. Creating PR review comments via the GitHub API requires pull-requests: write permission, causing the workflow to fail with a 403 Forbidden error when attempting to post comments.
Note
Adds BugBot config and tightens Claude Code Review workflow to trigger only on opened PRs with stricter, inline-comment guidance using gh api.
/.github/workflows/claude-code-review.ymlto trigger only onpull_request: [opened].gh apiwith the provided payload format.claude_argsto allowgh apiwhile keeping otherghcommands./.cursor/BUGBOT.mdwith concise rules for PR descriptions and reviews.Written by Cursor Bugbot for commit b49f9a7. This will update automatically on new commits. Configure here.