Skip to content

Conversation

@djeebus
Copy link
Contributor

@djeebus djeebus commented Nov 3, 2025

Note

Moves network storage selection to top-level, updates Pool to accept a Storage and adjusts local/KV storage constructors and call sites.

  • Network:
    • Pool API: NewPool now accepts a Storage and no longer returns an error; internal storage creation removed.
    • Storage selection: Introduce newStorage(nodeID, config) in main.go to choose between StorageLocal and StorageKV based on env/config.
    • Constructors:
      • NewStorageLocal(config) and NewStorageKV(nodeID, config) now infer vrtSlotsSize internally (remove slotsSize arg).
      • Remove NewStorage factory from storage.go.
  • Call sites:
    • Update orchestrator startup, build-template cmd, and benchmark to create storage (NewStorageLocal in non-prod paths) and pass it to network.NewPool.
    • Minor cleanup: remove unused UUID/clientID in benchmark.

Written by Cursor Bugbot for commit fd7a287. This will update automatically on new commits. Configure here.

@djeebus djeebus merged commit 9ac412b into main Nov 5, 2025
28 checks passed
@djeebus djeebus deleted the refactor-storage branch November 5, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants