-
Notifications
You must be signed in to change notification settings - Fork 201
Refactor dirty page tracking #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ValentaTomas
wants to merge
223
commits into
main
Choose a base branch
from
add-tracker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el uffd handling to a subpackage
dobrac
requested changes
Nov 10, 2025
Contributor
dobrac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in general, just few nits
packages/orchestrator/internal/sandbox/uffd/userfaultfd/userfaultfd.go
Outdated
Show resolved
Hide resolved
packages/orchestrator/internal/sandbox/uffd/userfaultfd/userfaultfd.go
Outdated
Show resolved
Hide resolved
packages/orchestrator/internal/sandbox/uffd/userfaultfd/userfaultfd.go
Outdated
Show resolved
Hide resolved
djeebus
reviewed
Nov 10, 2025
djeebus
reviewed
Nov 10, 2025
djeebus
reviewed
Nov 10, 2025
djeebus
reviewed
Nov 10, 2025
djeebus
approved these changes
Nov 10, 2025
dobrac
approved these changes
Nov 10, 2025
Member
Author
|
I'll do some last end-to-end testing and then we should be able to merge. |
6eb0bd8 to
070ddb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Replaces dirty page tracking with a thread-safe Tracker and updates UFFD, sandbox, and build components to use it, adding unregister support and minor API changes.
block.Tracker(thread-safe bitset) withHas,Add,Reset,Offsets,BitSet,Clone; unit tests added.SlicerwithBlockSize().uffd.New(memfile, socketPath); removeTrackedSliceDeviceusage.MemoryBackendAPI:Disable(ctx)now returns*block.Tracker.UFFDIO_UNREGISTER;Uffd.Disableunregisters then returnsTrackerfromDirty().block.Trackerwith bounded concurrency; expose offsets iterator in cross-process tests.Ready()channel.s.memory.Disable(ctx)and passdirty.BitSet()toMemoryDiffCreator.serveMemoryupdated for new UFFD constructor.BlockSize()toNoDiff,localDiff, andStorageDiff.utils.TransformToiterator helper.Written by Cursor Bugbot for commit b6a0c3a. This will update automatically on new commits. Configure here.