Skip to content

Conversation

@djeebus
Copy link
Contributor

@djeebus djeebus commented Oct 21, 2025

  • use provider=nomad explicitly
  • grpc is only supported by consul-integrated nomad clusters, use http instead
  • add tcp health check for orchestrator proxy port

Before:
image

After:
image


Note

Set provider="nomad", switch gRPC health checks to HTTP (/health), and add a TCP health check for the orchestrator proxy.

  • Nomad jobs:
    • iac/provider-gcp/nomad/jobs/orchestrator.hcl:
      • Service orchestrator: add provider = "nomad"; change health check from grpc to http with path = "/health".
      • Service orchestrator-proxy: add provider = "nomad"; add tcp health check.
    • iac/provider-gcp/nomad/jobs/template-manager.hcl:
      • Service template-manager: add provider = "nomad"; change health check from grpc to http with path = "/health".

Written by Cursor Bugbot for commit d6c8455. This will update automatically on new commits. Configure here.

port = "${port}"
name = "orchestrator"
port = "api"
provider = "nomad"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables the health checks to work. Without it, we default to consul, which doesn't function.

Comment on lines -17 to -18
grpc_use_tls = false
port = "${port}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this, as we're using HTTP (not GRPC) and it inherits the port of the service block that surrounds the check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarity—it inherits the check from orchestrator-proxy, not the orchestrator grpc, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It inherits the port, that's all:

job "orchestrator" {
    group "client" {
        service {
            name = "orchestrator"
            port = "1234"

            check {
                # inherits `port = "1234"`
            }
        }

        service {
            name = "proxy"
            port = "5678"

            check {
                # inherits `port = "5678"`
            }
        }
    }
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so there are still two healthchecks, right?

Copy link
Member

@ValentaTomas ValentaTomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just wanted to wait if @jakubno does not have any notes about some possible bad interaction with the current orchestrator job deploy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants