Create a strongly typed sandboxes map #1336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us a place to put sandbox-specific code, to execute on insert, on delete, etc
Note
Adds a sandbox-specific map with insert/remove hooks and execution-aware deletion, refactoring orchestrator components to use it.
sandbox.Map: Strongly-typed wrapper aroundsmapwithSubscribe,Insert,Remove,RemoveByExecutionID,Items,Get,Count, andNewSandboxesMap()ininternal/sandbox/map.go.RemoveByExecutionIDto avoid removing resumed sandboxes.*smap.Map[*sandbox.Sandbox]→*sandbox.Mapacross constructors and fields:proxy.NewSandboxProxy,hyperloopserver.NewHyperloopServer/handlers.NewHyperloopStore.metrics.NewSandboxObserver.internal/serverstructs andServiceConfig.build.Builder,layer.NewLayerExecutor, template serverserver.New.main.go,cmd/build-template,benchmark_test.go, andsandboxes_test.go.sandbox.NewSandboxesMap()to construct.sandboxes.Insert(id, sbx)withsandboxes.Insert(sbx).Written by Cursor Bugbot for commit fa22f6a. This will update automatically on new commits. Configure here.