Add peer-to-peer metrics tracker #1333
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| package server | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "go.uber.org/zap" | ||
| "golang.org/x/sync/semaphore" | ||
|
|
||
| "github.com/e2b-dev/infra/packages/orchestrator/internal/sharedstate" | ||
| featureflags "github.com/e2b-dev/infra/packages/shared/pkg/feature-flags" | ||
| "github.com/e2b-dev/infra/packages/shared/pkg/telemetry" | ||
| ) | ||
|
|
||
| type Limiter struct { | ||
| maxStartingSandboxes int64 | ||
|
|
||
| featureFlags *featureflags.Client | ||
| startingSandboxes *semaphore.Weighted | ||
| sharedStateManager *sharedstate.Manager | ||
| } | ||
|
|
||
| func NewLimiter( | ||
| maxStartingSandboxes int64, | ||
| featureFlags *featureflags.Client, | ||
| sharedStateManager *sharedstate.Manager, | ||
| ) *Limiter { | ||
| return &Limiter{ | ||
| featureFlags: featureFlags, | ||
| sharedStateManager: sharedStateManager, | ||
| maxStartingSandboxes: maxStartingSandboxes, | ||
| startingSandboxes: semaphore.NewWeighted(maxStartingSandboxes), | ||
| } | ||
| } | ||
|
|
||
| type TooManySandboxesRunningError struct { | ||
| Current, Max int | ||
| } | ||
|
|
||
| func (t TooManySandboxesRunningError) Error() string { | ||
| return fmt.Sprintf("max number of running sandboxes on node reached (%d), please retry", t.Max) | ||
| } | ||
|
|
||
| var _ error = TooManySandboxesRunningError{} | ||
|
|
||
| type TooManySandboxesStartingError struct { | ||
| Max int64 | ||
| } | ||
|
|
||
| var _ error = TooManySandboxesStartingError{} | ||
|
|
||
| func (t TooManySandboxesStartingError) Error() string { | ||
| return fmt.Sprintf("max number of starting sandboxes on node reached (%d), please retry", t.Max) | ||
| } | ||
|
|
||
| func (t *Limiter) AcquireStarting(ctx context.Context) error { | ||
| maxRunningSandboxesPerNode, err := t.featureFlags.IntFlag(ctx, featureflags.MaxSandboxesPerNode) | ||
| if err != nil { | ||
| zap.L().Error("Failed to get MaxSandboxesPerNode flag", zap.Error(err)) | ||
| } | ||
|
|
||
| runningSandboxes := t.sharedStateManager.TotalRunningCount() | ||
| if runningSandboxes >= maxRunningSandboxesPerNode { | ||
| telemetry.ReportEvent(ctx, "max number of running sandboxes reached") | ||
|
|
||
| return TooManySandboxesRunningError{runningSandboxes, maxRunningSandboxesPerNode} | ||
| } | ||
|
|
||
| // Check if we've reached the max number of starting instances on this node | ||
| acquired := t.startingSandboxes.TryAcquire(1) | ||
| if !acquired { | ||
| telemetry.ReportEvent(ctx, "too many starting sandboxes on node") | ||
|
|
||
| return TooManySandboxesStartingError{t.maxStartingSandboxes} | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (t *Limiter) ReleaseStarting() { | ||
| defer t.startingSandboxes.Release(1) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Error Type Mismatch in Sandbox Acquisition
The
AcquireStartingmethod returns a simpleErrTooManyStartingerror when the starting sandbox limit is reached. The calling code, however, expects aTooManySandboxesStartingErrortype forerrors.As()checks, which includesCurrentandMaxfields. This mismatch prevents proper error handling and loses specific context.