Skip to content

Conversation

@sitole
Copy link
Member

@sitole sitole commented Sep 22, 2025

  • Initial setup for hyperloop server (gin, generated openapi schema, request validation...)
  • Logs endpoint that received logs from sandbox and forwards them to Vector logs collector
  • Removed need for LOGS_COLLECTOR_PUBLIC_IP in orchestrator, replaced with hyperloop

@sitole sitole self-assigned this Sep 22, 2025
@sitole sitole added the feature New feature label Sep 22, 2025

# ======== IP ADDRESSES ====================

// todo: (2025-09-22): this can be removed when all orchestrator will be rolled with internal logs collector server
Copy link
Member Author

@sitole sitole Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sitole sitole removed their assignment Sep 22, 2025
@sitole sitole marked this pull request as ready for review September 22, 2025 12:18
cursor[bot]

This comment was marked as outdated.

@sitole
Copy link
Member Author

sitole commented Sep 22, 2025

Bug: Hyperloop Server Shutdown Context Issue

The hyperloop server's shutdown uses the main application context (ctx) instead of closeCtx. This is inconsistent with other services and means the server won't respect shutdown timeouts or immediate cancellation during forced stops, potentially causing it to hang or fail prematurely.

packages/orchestrator/main.go#L529-L534

Thank you, good bot!

@sitole
Copy link
Member Author

sitole commented Sep 22, 2025

cca1c51 fixes the issue introduced at #1105 that caused all sandbox logs coming from new envd builds to never show to customers, as the teamID we are using for log filtration was removed.

schema:
$ref: "#/components/schemas/Me"

/:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move it under /logs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we need to send it somehow to envd. Now we are using address parameter in the init request, and with adding back compatibility, we would need to send /logs here too, to make it not re-usable for different things.

Maybe we can do /logs, update in newer envds and do / just for back compatibility in http server?

@sitole sitole requested a review from jakubno September 22, 2025 14:27
@sitole
Copy link
Member Author

sitole commented Sep 22, 2025

dd5cede is just wip for now. Moves url for sandbox logs to /logs/push with back compatibility for older envd. Re-do of metadata sync in envd.

cursor[bot]

This comment was marked as outdated.

@sitole sitole force-pushed the feat/hyperloop-gin-server branch from dd5cede to 569ed9f Compare September 23, 2025 08:41
@sitole
Copy link
Member Author

sitole commented Sep 23, 2025

@sitole sitole merged commit 6662158 into main Sep 23, 2025
26 checks passed
@sitole sitole deleted the feat/hyperloop-gin-server branch September 23, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants