-
Notifications
You must be signed in to change notification settings - Fork 30
Chore: Prettier format + file clean-up #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR performs a comprehensive code formatting and cleanup using Prettier, specifically addressing import statement ordering introduced in #94. The changes also include removal of unused story files for Storybook components and cleanup of various code files.
- Reformatted import statements for consistent ordering across all files
- Removed unused Storybook story files to clean up the codebase
- Updated logger implementation to use structured logging with Winston
- Cleaned up various code formatting inconsistencies
Reviewed Changes
Copilot reviewed 247 out of 259 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
vitest.config.ts | Reordered import statements |
src/ui/*.tsx | Reformatted import statements and export orders |
src/ui/stories/*.tsx | Removed unused Storybook story files |
src/ui/primitives/*.tsx | Consistent import/export ordering |
src/lib/clients/logger.ts | Replaced simple console logger with Winston-based structured logging |
src/server//.ts | Updated logging calls and import formatting |
src/styles/*.css | Formatted CSS with proper line breaks |
src/types/database.types.ts | Changed double quotes to single quotes |
src/ui/matrix-rain.tsx | Removed entire unused component file |
src/lib/clients/api.ts
Outdated
@@ -8,6 +8,7 @@ export const infra = createClient<InfraPaths>({ | |||
headers, | |||
body, | |||
method, | |||
// @ts-expect-error -- duplex not on type, keep it for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @ts-expect-error comment should provide more context about why duplex is needed and what the expected resolution is. Consider adding a TODO or issue reference for when this can be properly addressed.
// @ts-expect-error -- duplex not on type, keep it for now | |
// @ts-expect-error -- The 'duplex' property is not part of the fetch API type definition. | |
// It is required here to support streaming requests when a body is present. | |
// TODO: Investigate and update the type definitions or find an alternative approach. |
Copilot uses AI. Check for mistakes.
src/instrumentation.ts
Outdated
@@ -3,6 +3,9 @@ import * as Sentry from '@sentry/nextjs' | |||
export async function register() { | |||
if (process.env.NEXT_RUNTIME === 'nodejs') { | |||
await import('../sentry.server.config') | |||
await import('winston') | |||
// @ts-expect-error no types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @ts-expect-error comment 'no types' is too vague. Consider specifying which module lacks types and whether this is expected to be resolved in the future.
// @ts-expect-error no types | |
// @ts-expect-error: The 'next-logger' module lacks TypeScript definitions. | |
// This is expected as the module does not provide types, and there are no plans to add them. |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a github actions to check linting / prettier
@jakubno next build runs tsx and eslint. |
This commit introduces a new logging configuration using Winston, enhancing error handling and logging capabilities across the application. The `next-logger` configuration file has been added, and the logger is integrated into various components, replacing previous logging methods. Additionally, several dependencies have been updated, including React, Next.js, and various development tools, ensuring compatibility and improved performance.
…tion, replacing previous logging methods for improved error handling. It also updates several dependencies, including React and Next.js, to their latest versions, ensuring better performance and compatibility. Additionally, new plugins for Prettier have been added to the configuration, and unnecessary schema validations have been removed from the codebase.
…_URL import location
16509f4
to
9719934
Compare
…tation (e2b-dev#100) This commit adds OpenTelemetry registration to the instrumentation module, enabling better observability for the dashboard service. The configuration includes context propagation for fetch requests, enhancing the tracking of performance metrics.
This pr only cleans up unused resources + has run prettier formatting since #94 introduced a new prettier tooling for import statements.