fix(git): prevent crash on malformed branch lines and false detached HEAD detection#1521
Open
AdaAibaby wants to merge 1 commit into
Open
fix(git): prevent crash on malformed branch lines and false detached HEAD detection#1521AdaAibaby wants to merge 1 commit into
AdaAibaby wants to merge 1 commit into
Conversation
…HEAD detection
- Use split('...', 1) / indexOf('...') to avoid ValueError when the
branch line contains multiple '...' sequences (e2b-dev#1371)
- Remove overly broad 'detached' substring check that misidentified
branches like 'fix-detached-bug' as detached HEAD (e2b-dev#1373)
- Add unit tests for both Python and JS SDKs covering edge cases
Fixes e2b-dev#1371, fixes e2b-dev#1373
AdaAibaby
requested review from
ValentaTomas,
jakubno and
mishushakov
as code owners
🦋 Changeset detectedLatest commit: f3a47ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in
parseGitStatus/parse_git_statusfor both Python and JS SDKs:Bug 1: Crash on branch lines containing multiple
...(#1371)split("...")without a limit causes aValueError(Python) or incorrect destructuring (JS) when the normalized branch line contains more than one...sequence.Fix:
split("...", 1)to limit the splitindexOf("...")+slice()instead of destructuringsplit("...")Bug 2: False detached HEAD detection (#1373)
The broad substring check
"detached" in raw_branch(Python) /rawBranch.includes('detached')(JS) incorrectly identifies branches likefix-detached-bugorfeature/detached-modeas detached HEAD state.Fix: Remove the overly broad substring check, keeping only the precise
startsWith("HEAD (detached at ")check which matches git's actual output format.Tests
Added 10 unit tests for each SDK covering edge cases:
Fixes #1371, fixes #1373
/cc @mishushakov Would appreciate your review, thanks!