chore(js): modernize networking deps and raise Node floor to 22#1512
chore(js): modernize networking deps and raise Node floor to 22#1512mishushakov wants to merge 3 commits into
Conversation
Move @connectrpc/connect and @connectrpc/connect-web off the 2.0.0-rc.3 pre-release pin to the stable ^2.1.2 line, bump @bufbuild/protobuf to ^2.12.1, and upgrade undici 7 -> ^8.5.0. undici 8 requires Node >=22.19.0, so raise the minimum supported Node version for both the e2b SDK and @e2b/cli from 20 (EOL 2026-04-30) to 22.19.0, and bump @types/node to ^22. Also bump the React test dependencies to v19 (adding react-dom and @types/react-dom), update CI's .tool-versions Node to 22.23.1, and standardize actions/setup-node to v6 across all workflows. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 7e94409 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR SummaryMedium Risk Overview The JS SDK moves Connect and connect-web from Reviewed by Cursor Bugbot for commit 7e94409. Bugbot is set up for automated code reviews on this repo. Configure here. |
Package ArtifactsBuilt from a0c5492. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.31.1-mishushakov-modernize-js-dependencies.0.tgzCLI ( npm install ./e2b-cli-2.13.1-mishushakov-modernize-js-dependencies.0.tgzPython SDK ( pip install ./e2b-2.30.0+mishushakov.modernize.js.dependencies-py3-none-any.whl |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b31ef9549f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
… floor Address Claude review findings on #1512: - codegen.Dockerfile pinned NODE_VERSION to 20.19.5 while .tool-versions moved to 22.23.1; since generated_files.yml triggers on .tool-versions and engine-strict=true, the codegen container would run Node 20 against packages now requiring >=22.19.0. Bump the pin to 22.23.1. - skills/stripe-projects/SKILL.md still claimed Node 20; update to 22.19.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…-js-dependencies # Conflicts: # packages/js-sdk/package.json # pnpm-lock.yaml
huv1k
left a comment
huv1k
left a comment
There was a problem hiding this comment.
I am approving it even though I think we should more respect semver versioning 😅
2 participants
Moves the JS SDK's Connect/Protobuf stack off the
2.0.0-rc.3pre-release pin to stable (@connectrpc/connect/connect-web→^2.1.2,@bufbuild/protobuf→^2.12.1) and upgradesundici7 →^8.5.0. Because undici 8 requires Node>=22.19.0, the minimum supported Node for bothe2band@e2b/cliis raised from 20 (EOL 2026-04-30) to22.19.0, with@types/nodebumped to^22. Also bumps the React test dependencies to v19 (addingreact-dom/@types/react-dom), updates CI's.tool-versionsNode to22.23.1, and standardizesactions/setup-nodetov6across all workflows. No public SDK API changes — verified via typecheck, build, lint, the mocked Connect/undici transport tests, and 106 live filesystem/command tests over the new stack.🤖 Generated with Claude Code