Skip to content

Keep integration attribution on connection config#1459

Merged
matthewlouisbrockman merged 3 commits into
mainfrom
attribution/private-connection-config
Jun 27, 2026
Merged

Keep integration attribution on connection config#1459
matthewlouisbrockman merged 3 commits into
mainfrom
attribution/private-connection-config

Conversation

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor

moves integration attirbution to more private thing to avoid confusing people with first class kwargs

@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 96d7cb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
e2b Patch
@e2b/python-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cursor

cursor Bot commented Jun 18, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Removes a public option from shared API param types and changes Python header rebuild behavior, which can break integrators that passed integration outside ConnectionConfig.

Overview
integration is removed from the shared ConnectionOpts / ApiParams surface so sandbox, template, volume, and per-request kwargs no longer expose it; JS adds ConnectionConfigOpts and exports it, and Python drops integration from the ApiParams TypedDict while keeping it on ConnectionConfig.__init__.

Python get_api_params no longer reads an integration override from call kwargs and always applies attribution from the config instance when rebuilding headers; constructor logic only sets a default User-Agent when integration is set or User-Agent is missing. Tests now pass integration via ConnectionConfig / get_api_params() instead of sandbox connect kwargs.

Callers who relied on integration as a first-class sandbox or API param will need to set it on ConnectionConfig instead; that is a breaking typing and runtime change for those call patterns.

Reviewed by Cursor Bugbot for commit 96d7cb0. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Package Artifacts

Built from 26da1f6. Download artifacts from this workflow run.

JS SDK (e2b@2.31.1-attribution-private-connection-config.0):

npm install ./e2b-2.31.1-attribution-private-connection-config.0.tgz

CLI (@e2b/cli@2.13.1-attribution-private-connection-config.0):

npm install ./e2b-cli-2.13.1-attribution-private-connection-config.0.tgz

Python SDK (e2b==2.30.0+attribution-private-connection-config):

pip install ./e2b-2.30.0+attribution.private.connection.config-py3-none-any.whl

@mishushakov mishushakov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

Comment thread packages/js-sdk/src/connectionConfig.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/rpcHeaders.test.ts Outdated
Comment thread packages/js-sdk/tests/connectionConfig.test.ts
Comment thread packages/python-sdk/e2b/connection_config.py Outdated
Comment thread packages/python-sdk/e2b/connection_config.py
Comment thread packages/python-sdk/e2b/connection_config.py
@matthewlouisbrockman matthewlouisbrockman force-pushed the attribution/private-connection-config branch from 8822e93 to d5f44bd Compare June 23, 2026 01:54
Comment thread packages/python-sdk/e2b/connection_config.py Outdated
Comment thread packages/python-sdk/e2b/connection_config.py Outdated
@matthewlouisbrockman matthewlouisbrockman force-pushed the attribution/private-connection-config branch from d5f44bd to e5b35b8 Compare June 23, 2026 18:53

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 96d7cb0. Configure here.

Comment thread packages/python-sdk/e2b/connection_config.py
@matthewlouisbrockman matthewlouisbrockman merged commit f160f08 into main Jun 27, 2026
62 of 72 checks passed
@matthewlouisbrockman matthewlouisbrockman deleted the attribution/private-connection-config branch June 27, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants