Implemented custom sorting for e_tree_model #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #3025, e_tree_model sorting was reimplemented in pure PHP, but this broke custom sorting (like `?field=cat_name&asc=desc`). This commit introduces a hack that simulates a subset of MySQL/MariaDB ORDER BY clauses, which should be sufficient for all known custom sorting that can be requested. Tree formatting is always preserved, but custom sorting will apply for all items at a certain depth under the same parent. This commit also contains some minor formatting fixes and makes a minor change to some regex to make use of non-capturing groups. Fixes: #3029
Subclasses may forget to run code to do a total record count, which
leads to output showing "Total Records: 0" on some pages with lists,
like `/e107_admin/links.php`.
This commit cuts out the record counting from the getList() method of
any e_admin_form_ui subclasses and the base class so that subclasses do
not have to reimplement record counting.
The caveat with this implementation is that it violates the Law of
Demeter, as evidenced by the new chained method call:
$this->getController()->getTreeModel()->getTotal()
Jumping through two objects to get a value is not ideal, but this is the
code we have to work with at the moment.
|
👍 Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3025, e_tree_model sorting was reimplemented in pure PHP, but this broke custom sorting (like
?field=cat_name&asc=desc).This pull request introduces a hack that simulates a subset of MySQL/MariaDB
ORDER BYclauses, which should be sufficient for all known custom sorting that can be requested.Tree formatting is always preserved, but custom sorting will apply for all items at a certain depth under the same parent.
This pull request also contains some minor formatting fixes and makes a minor change to some regex to make use of non-capturing groups.
Fixes: #3029