Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1852

Merged
merged 6 commits into from
Jan 16, 2023
Merged

Conversation

richardebeling
Copy link
Member

No description provided.

Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good, haven't looked at OIDC changelog yet;

Do you think we will spread StrOrPromise throughout the repo now? I hope we can keep it somehow contained

Mypy passes locally for me

evap/staff/views.py Outdated Show resolved Hide resolved
@richardebeling
Copy link
Member Author

@niklasmohrin OIDC changelog is very small and shouldn't have anything that affects us.

I don't really know about StrOrPromise. For now, it seems the impact is manageable, we only need to annotate lazy translations, and theoreteically we can evaluate them to str as soon as we know the target language, which I think most often will be the first usage of a global constant of type _StrPromise. As discussed in django-stubs, str and _StrPromise really aren't safely interchangable, so I guess even if this is somewhat invasive, it's the only way to have type annotations that we can rely on.

@niklasmohrin
Copy link
Member

If I understand you correctly, we could safely evaluate them to str wherever we would also use gettext non-lazy?

@richardebeling richardebeling merged commit 370cd33 into e-valuation:main Jan 16, 2023
@richardebeling richardebeling deleted the dependencies branch January 16, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants