-
-
Notifications
You must be signed in to change notification settings - Fork 58
AMOS 2025 - Worker mangement and orchestration #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: Luka Dekanozishvili <luka.dekanozishvili1@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ashiven <nevisha@pm.me>
Co-authored by Johannes Kunow <j.kunow@tu-berlin.de> Signed-off-by: Fridtjof Damm <soenke.f.damm@campus.tu-berlin.de>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ashiven <nevisha@pm.me>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
IS_UBUNTU=$(awk -F= '/^NAME/{print $2}' /etc/os-release) | ||
[[ ${IS_UBUNTU} == "Ubuntu" ]] && IS_UBUNTU=true || IS_UBUNTU=false | ||
|
||
function downloadPackage() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find a word-splitting issue here, what did you find?
However, I noticed that the result of the awk
command includes quotes, thus the comparison is always false. I updated the check.
Signed-off-by: ClProsser <clemens.prosser@gmail.com>
Now, this PR is not in draft-state anymore. Three problems should be addressed soon:
Furthermore, it might be reasonable to refactor the If there are any change requests in this PR, feel free to comment them in this PR, depending on its size we'll fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
Looking forward to merging this
...once I have tested it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure why this file is called that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this file we define the function new_autoadd_client
, which uses paramiko.AutoAddPolicy
. However, CodeQL does not allow this (https://codeql.github.com/codeql-query-help/python/py-paramiko-missing-host-key-validation/). The only way to define exceptions is to exclude whole files. Thus a file codeql_ignore.py
was created, and added to /codeql-config.yml
.
What kind of change does this PR introduce?
feature
What is the current behavior?
Currently, worker nodes are not supported by EMBArk.
What is the new behavior (if this is a feature change)?
In this PR, we provide a basic implementation of our project mission: Orchestration in EMBArk, including worker setup/configuration. As of now, it is possible to create workers, configure/update them, run an analysis on them and retrieve results.
This PR includes:
Does this PR introduce a breaking change?
No
Other information:
This is the third and main release of the AMOS 2025 EMBArk project.
As we are still testing the system as a whole, this is a draft PR. The prevention of overlapping IP ranges and SSH key auth is not included yet.