Installer Update #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add gcc and build-essential for objdump installation Add aha installation for Report Manager
p4cx
suggested changes
Nov 25, 2020
| @@ -111,3 +113,20 @@ if ! [[ -f "external/objdump" ]] ; then | |||
| else | |||
| echo -e "$ORANGE""objdump is already downloaded and compiled""$NC" | |||
| fi | |||
|
|
|||
| # aha for html generation | |||
| echo -e "\\n""$ORANGE""$BOLD""Downloading aha""$NC" | |||
There was a problem hiding this comment.
Your code won't work at my system. I tried it with some little changes, please fix it :)
# aha for html generation
echo -e "\\n""$ORANGE""$BOLD""Downloading aha""$NC"
if ! [[ -f "external/aha-master" ]] ; then
apt-get install make
apt-get install unzip
wget https://github.com/theZiz/aha/archive/master.zip -O external/aha-master.zip
unzip ./external/aha-master.zip -d ./external
cd ./external/aha-master || exit 1
echo -e "$ORANGE""$BOLD""Compile aha""$NC"
make
cd ../.. || exit 1
mv "external/aha-master/aha" "external/aha"
rm -R external/aha-master
else
echo -e "$ORANGE""aha is already downloaded and compiled""$NC"
fi
I don't know, if aha needs stuff from the zip archive. I deleted the unzipped archive to keep the external directory clean. If it won't work, change it.
There was a problem hiding this comment.
Thank you, the changes are fine.
Furthermore I have added rm ./external/aha-master.zip to remove the zip file. Now everything should be clean.
p4cx
approved these changes
Nov 25, 2020
m-1-k-3
referenced
this pull request
in m-1-k-3/emba
Nov 30, 2020
m-1-k-3
referenced
this pull request
in m-1-k-3/emba
Mar 29, 2021
m-1-k-3
referenced
this pull request
in m-1-k-3/emba
Jun 21, 2021
m-1-k-3
referenced
this pull request
in m-1-k-3/emba
Aug 4, 2021
HoxhaEndri
pushed a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gcc and build-essential for objdump installation
Add aha installation for Report Manager