Make implementation independent #16
Conversation
|
@tmoers changes look pretty good, I'm just curious why your commits don't link to your github user? |
|
@nmbro Oh, thanks for pointing that out because I didn't notice that. I guess it's because I did the changes on my work laptop where git is configured for my work's gitlab. I'll do my best to remember changing it for the next time :) |
Is there a chance you could update the commits with your own email address in that case? (squash into one is OK) |
|
Apparently you can configure multiple email addresses in github. I just did that. Does it show correctly now? (For me it looks ok now) |
There is no reason to be dependent on the google implementation of gRPC. If we take a dependency on `Grpc.Core.Api`, which is shared by both the Microsoft and the Google implemention, then this library can be used regardless if the consuming application already switched to the recommended Microsoft implementation.
tmoers
force-pushed
the
impl/make-implementation-independent
branch
from
32ef2af to
bf60727
Compare
|
@tmoers thanks for your contributions! |
|
@nmbro |
Google has deprecated its C# gRPC implementation (
Grpc.Core) that isbased on the native C library in favor of the Microsoft implementation.
Fortunately, both implementations share the same type definitions to ensure
an easy migration. Because this library only needs the types defined in this
shared package, it is sufficient to only take this minimal dependency to make
the prometheus interceptor library implementation independent.
The test project can stay dependent on the full google implementation.
[1] https://grpc.io/blog/grpc-csharp-future/