Repository navigation
refactor(mappingutils): use correct logger and remove log stuffing on… - #209
Merged
Merged
Conversation
… unresolved references
nico-mcalley
left a comment
nico-mcalley
left a comment
Collaborator
There was a problem hiding this comment.
change looks good and works fine, but let us discuss my questions please.
| resolvedReferences | ||
| ).join('],[')}]}` | ||
| logger?.warn( | ||
| `[denormalizeResolvedReferences] Unable to find object [${referencedId}] during denormalization.` |
Collaborator
There was a problem hiding this comment.
Why do you drop the keys?
Collaborator
There was a problem hiding this comment.
wouldn't it be good to debug log the resolved references keys?
nico-mcalley
approved these changes
May 3, 2024
github-actions Bot
pushed a commit
that referenced
this pull request
May 3, 2024
## [10.22.2](v10.22.1...v10.22.2) (2024-05-03) ### Bug Fixes * **mappingutils:** use correct logger ([#209](#209)) ([ff2253c](ff2253c))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… unresolved references