refactor: rename pasteUrl to be more semantically correct #3
+8
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors pasteUrl to make it more generic and eliminates the confusion with the name of the function (paste implies pasting versus copying). Plus, who knows what else you might want to copy to the clipboard as part of some future action? Also, renamed copyUrlToClipboard to be more specific about the current URL to avoid confusion about copying a URL selected via a mark.
|
@pkazmier thank you overall, it was all very quick done for personal use mostly plus there are some changes coming, which may be a 0.1 version something - mostly a better logic compartmentalization to proper modules and bindings rewrite, so they will be not hardcoded in code like now anymore, thus easily configurable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small stuff, just wanted to contribute back in some way.
This commit refactors
pasteUrlto make it more generic and eliminates the confusion with the name of the function (paste implies pasting versus copying). Plus, who knows what else you might want to copy to the clipboard as part of some future action? Also, renamedcopyUrlToClipboardto be eliminate confusion about copying the current URL versus copying a URL selected via a mark.