Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added close_connection() to sap_rfc #709

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

AnnaGerlich
Copy link
Contributor

Summary

Added close_connection() to ensure closing connection after each session.
This change is in line with the viadot main branch: #676

Importance

Closing connection after each session will fix error with too many open connections in SAP as there is a limit of open SAP connections.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@AnnaGerlich AnnaGerlich changed the title Sap close con ✨ Added close_connection() to sap_rfc Jun 21, 2023
@AnnaGerlich AnnaGerlich requested a review from trymzet June 21, 2023 11:16
@AnnaGerlich AnnaGerlich added bug Something isn't working 2.0 viadot 2.0 labels Jun 21, 2023
viadot/sources/sap_rfc.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Michał Zawadzki <michalmzawadzki@gmail.com>
@trymzet
Copy link
Contributor

trymzet commented Jun 21, 2023

@AnnaGerlich pls create issue for contributing.md process as discussed

@trymzet trymzet self-requested a review June 21, 2023 13:05
@trymzet trymzet merged commit 8b902c4 into dyvenia:2.0 Jun 21, 2023
@AnnaGerlich AnnaGerlich deleted the sap_close_con branch June 22, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 viadot 2.0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants