Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add get_object_sizes method to S3 source #1092

Merged
merged 2 commits into from
Oct 11, 2024
Merged

✨ Add get_object_sizes method to S3 source #1092

merged 2 commits into from
Oct 11, 2024

Conversation

Rafalz13
Copy link
Contributor

Summary

Added a new method to calculate the size of single or multiple objects in S3.

Importance

This functionality was missing. It is used in the other flow. It was important to move it to the source class.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@Rafalz13 Rafalz13 added enhancement New feature or request 2.0 viadot 2.0 labels Oct 11, 2024
@Rafalz13 Rafalz13 requested a review from trymzet October 11, 2024 10:29
@trymzet trymzet merged commit 5122467 into 2.0 Oct 11, 2024
4 checks passed
@trymzet trymzet deleted the s3_get_object_sizes_method branch October 11, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trymzet trymzet trymzet approved these changes

Assignees
No one assigned
Labels
2.0 viadot 2.0 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rafalz13 @trymzet