fix(src/theme/navbar/index.js): fix the wrong validation for mobile s… #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dks in navbar The validation for the color of navbar was wrong for mobile-sdks page which was web-sdk earlier. #58
vaibhavshn
approved these changes
Jun 23, 2022
Member
vaibhavshn
left a comment
vaibhavshn
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for reporting and fixing it!
|
The PR wasn't made to a repo handled by gitops, I will not make an update on the gitops repo. |
|
🎉 This PR is included in version 1.14.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
vaibhavshn
pushed a commit
that referenced
this pull request
Aug 16, 2022
…config-format-on-docs-dyte-io feat(recording): documentation for Azure, and maxSeconds, fileNamePrefix parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation for the color of navbar was wrong for mobile-sdks page which was web-sdk earlier.
#58
Description
This PR fixes the random behavior of navbar which was due to typo im validation of the mobile SDKw.r.t to selection of Navbar elements. The mobile-sdk was validated with text web-sdk which turned out to be affecting two elements simultaneously. The typo is fixed in this PR.
Resolved issues
Closes #1