-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): node container log stream sharing #942
Conversation
37ba383
to
de7f190
Compare
6f27ae0
to
9fe2907
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #942 +/- ##
===========================================
+ Coverage 17.94% 17.99% +0.05%
===========================================
Files 346 350 +4
Lines 17467 17606 +139
Branches 1027 1029 +2
===========================================
+ Hits 3135 3169 +34
- Misses 14143 14249 +106
+ Partials 189 188 -1 ☔ View full report in Codecov by Sentry. |
8c0ac27
to
8dc76da
Compare
2730ec8
to
89ab1c5
Compare
ae07635
to
30eb79e
Compare
30eb79e
to
b2772bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I have got a fresh pair of eyes 👀
I've checked the Go part, that looks good. 👍 My comments are mostly wording related.
I've skimmed the TS part too, but that would better be checked by some else.
0e925d5
to
8eaf483
Compare
8eaf483
to
4d027e8
Compare
b0520be
to
45bf005
Compare
_
as global container namespace.