Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dagent): add permanent global envs and traefik upload limit #890

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

nandor-magyar
Copy link
Contributor

This PR includes two small things:
First, namespace-wide shared envs was not possible it now mirrors crane functionality.
Second, Traefik upload limit is in different format compared to ingress (nginx), so if the values are provided in the latter's format it will be parsed.

@nandor-magyar nandor-magyar requested a review from a team as a code owner December 6, 2023 09:42
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. lang:golang labels Dec 6, 2023
golang/pkg/dagent/utils/docker.go Outdated Show resolved Hide resolved
golang/pkg/dagent/utils/environment.go Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (9adfc30) 25.99% compared to head (b90d390) 26.11%.

Files Patch % Lines
golang/pkg/dagent/utils/docker.go 0.00% 39 Missing ⚠️
golang/pkg/dagent/utils/environment.go 60.00% 14 Missing and 6 partials ⚠️
golang/pkg/dagent/utils/traefik.go 40.00% 6 Missing and 3 partials ⚠️
golang/internal/domain/domain.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #890      +/-   ##
===========================================
+ Coverage    25.99%   26.11%   +0.11%     
===========================================
  Files           70       71       +1     
  Lines         7481     7583     +102     
===========================================
+ Hits          1945     1980      +35     
- Misses        5382     5440      +58     
- Partials       154      163       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nandor-magyar nandor-magyar requested a review from m8vago December 6, 2023 14:30
@nandor-magyar nandor-magyar merged commit 77b17e1 into develop Dec 6, 2023
26 checks passed
@nandor-magyar nandor-magyar deleted the feat/dagent-global-env-variables branch December 6, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:golang pr:feat source:agent The scope of the issue or pull request is agent.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants