Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

fix(readme): add imports, remove outdated link, add statement to install dependency #38

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

pichlermarc
Copy link
Member

Changes:

  • The docs we linked to are down, I removed the link and added info about the necessary imports instead.
  • The example was missing instructions to install psutil (when used without a script), so I added a line to do so

Copy link
Member

@pirgeo pirgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OTel versions specified are minimum versions, in the tests, it uses opentelemetry-api and opentelemetry-sdk version 1.16.0 (the latest version). I don't think we need to update any dependency versions.

@pichlermarc
Copy link
Member Author

The OTel versions specified are minimum versions, in the tests, it uses opentelemetry-api and opentelemetry-sdk version 1.16.0 (the latest version). I don't think we need to update any dependency versions.

Yep, the current range picks up 1.16 automatically 🙂

@pichlermarc pichlermarc merged commit 6a86c53 into main Mar 13, 2023
@pichlermarc pichlermarc deleted the feat/sdk-1.16 branch March 13, 2023 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants