Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Disable cookie processing by default #34

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Feb 26, 2024

Override default value of @cookies configuration option. Fixes an issue where a local Active Gate sets a cookie using the dynatrace.com domain and logstash HTTP client logs a warning.

This is a breaking change because it disables cookie processing by default. This means if a load balancer or API gateway was using cookies for something, they will no longer be sent with requests. This should be safe, but I think it's good to call out as a break anyway since it is a behavioral change.

Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dyladan dyladan requested a review from arminru February 26, 2024 19:22
@dyladan dyladan merged commit 65f3eb8 into main Feb 27, 2024
5 checks passed
@dyladan dyladan deleted the disable-cookies branch February 27, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants