Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use user agent version format #21

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Use user agent version format #21

merged 3 commits into from
Sep 23, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Sep 22, 2022 •
edited by arminru
Loading

Update user agent version format to follow RFC 7231, 5.5.3.

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dyladan
Copy link
Member Author

dyladan commented Sep 22, 2022

Failing test came from a timeout. Running again

@arminru arminru merged commit 8255d31 into main Sep 23, 2022
@arminru arminru deleted the hardcode-version branch September 23, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminru arminru arminru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyladan @arminru