-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement-handling-of-ipv6-addresses-reserved-ranges #84
Merged
lnarolski
merged 5 commits into
main
from
implement-handling-of-ipv6-addresses-reserved-ranges
Jun 6, 2024
Merged
implement-handling-of-ipv6-addresses-reserved-ranges #84
lnarolski
merged 5 commits into
main
from
implement-handling-of-ipv6-addresses-reserved-ranges
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubrak
reviewed
May 8, 2024
jakubrak
reviewed
May 10, 2024
lnarolski
force-pushed
the
implement-handling-of-ipv6-addresses-reserved-ranges
branch
from
May 27, 2024 07:06
ff9a8ea
to
1a155a3
Compare
lnarolski
force-pushed
the
implement-handling-of-ipv6-addresses-reserved-ranges
branch
from
May 29, 2024 13:49
1a155a3
to
9f10e8f
Compare
pawsten
reviewed
Jun 3, 2024
pawsten
reviewed
Jun 3, 2024
pawsten
reviewed
Jun 3, 2024
pawsten
reviewed
Jun 3, 2024
pawsten
reviewed
Jun 3, 2024
pawsten
reviewed
Jun 3, 2024
jakubrak
reviewed
Jun 4, 2024
jakubrak
approved these changes
Jun 5, 2024
pawsten
approved these changes
Jun 5, 2024
lnarolski
deleted the
implement-handling-of-ipv6-addresses-reserved-ranges
branch
June 6, 2024 07:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
Currently eBPF Discovery only partially handles IPv6 addressing, that is mapped IPv4 into IPv6. Other IPv6 http requests are neglected and not counted as internal/external clients for discovered services.
Solution proposal
IpAddressNetlinkChecker::isV6AddressExternal() implement checks (check if address prefix matches the one provided) for:
getMappedIPv4Addr() add checks for IPv4/IPv6 translated address
check for prefixes: (::ffff:0:0:0/96) and (64:ff9b::/96) and handle as mapped IPv4/IPv6
Success criteria
IPv6 addresses are recognized as local if any of the following rules apply:
Unit tests added for all implemented rules