Add external ip connections counters for each service #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnarolski
force-pushed
the
Add-external-ip-connections-counters-for-each-service
branch
3 times, most recently
from
96a5e5a
to
e5c7bea
Compare
lnarolski
force-pushed
the
Add-external-ip-connections-counters-for-each-service
branch
2 times, most recently
from
4126294
to
86a5ec6
Compare
lnarolski
changed the title
lnarolski
requested review from
hparzych,
asias91,
pawsten,
kamiljoner,
divano-kot and
jakubrak
lnarolski
force-pushed
the
Add-external-ip-connections-counters-for-each-service
branch
from
86a5ec6
to
d8fa245
Compare
|
I've duplicated component tests for |
pawsten
reviewed
Nov 12, 2024
asias91
requested changes
Nov 14, 2024
pawsten
previously approved these changes
Nov 14, 2024
asias91
reviewed
Nov 14, 2024
asias91
approved these changes
Nov 14, 2024
lnarolski
deleted the
Add-external-ip-connections-counters-for-each-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each service line in ebpf-discovery output added externalIPv4_16ClientNets, externalIPv4_24ClientNets and externalIPv6ClientsNets counters.
We want to adjust exposed for public traffic information to the new algorithm. The current implementation is wrong and need to be fixed. The first step is to publish missing data from ebpf to osagent.