Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase line length limit #14

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Increase line length limit #14

merged 2 commits into from
Jun 1, 2022

Conversation

pirgeo
Copy link
Member

@pirgeo pirgeo commented May 30, 2022

Also truncated the line, since printing a line with more than 50k characters is probably not helpful.

pichlermarc
pichlermarc approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a golang expert, but looks good to me 👍

metric/metric_test.go Outdated Show resolved Hide resolved
joaopgrassi
joaopgrassi reviewed May 31, 2022
View reviewed changes
metric/metric.go Outdated Show resolved Hide resolved
@pirgeo pirgeo merged commit 470b482 into main Jun 1, 2022
@pirgeo pirgeo deleted the linelength branch June 1, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@pichlermarc pichlermarc pichlermarc approved these changes

@dyladan dyladan Awaiting requested review from dyladan

@arminru arminru Awaiting requested review from arminru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pirgeo @joaopgrassi @pichlermarc