Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer move to the next token when parsing an is or as expression #289

Merged
merged 4 commits into from
Jun 11, 2023

Conversation

metoule
Copy link
Contributor

@metoule metoule commented Jun 10, 2023

After the changes introduced in #178, the parser no longer needs to move to the token after the known type.

Fixes #287

Copy link
Member

@davideicardi davideicardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR as usual! Thank you!

Maybe you can just add as test the case 'string.IsNullOrEmpty(variable as string))'?
The one mentioned in the bug...

@metoule
Copy link
Contributor Author

metoule commented Jun 11, 2023

Good idea, I've added the test for the case mentioned in the bug report

@metoule metoule merged commit dfa3277 into dynamicexpresso:master Jun 11, 2023
@metoule metoule deleted the fix_287 branch June 11, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing exception while using 'as' operator
2 participants