Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Elemental 4 #3

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jan 19, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #3 into master will decrease coverage by 43.75%.
The diff coverage is 36.36%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master       #3       +/-   ##
=============================================
- Coverage       100%   56.25%   -43.75%     
- Complexity        2        5        +3     
=============================================
  Files             1        1               
  Lines             6       16       +10     
=============================================
+ Hits              6        9        +3     
- Misses            0        7        +7
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementImage.php 56.25% <36.36%> (-43.75%) 5 <3> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8402478...956e000. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #3 into master will decrease coverage by 43.75%.
The diff coverage is 36.36%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master       #3       +/-   ##
=============================================
- Coverage       100%   56.25%   -43.75%     
- Complexity        2        5        +3     
=============================================
  Files             1        1               
  Lines             6       16       +10     
=============================================
+ Hits              6        9        +3     
- Misses            0        7        +7
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementImage.php 56.25% <36.36%> (-43.75%) 5 <3> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8402478...956e000. Read the comment docs.

@jsirish jsirish merged commit 2f2ddca into dynamic:master Jan 19, 2019
@jsirish jsirish deleted the refactor/branchAlias branch January 19, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant