Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR Allow PHP 8.0 #19

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jul 8, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #19 (ffb7937) into master (99aabe8) will decrease coverage by 1.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
- Coverage     90.32%   89.28%   -1.04%     
  Complexity       12       12              
============================================
  Files             2        2              
  Lines            62       56       -6     
============================================
- Hits             56       50       -6     
  Misses            6        6              
Flag Coverage Δ
php ?
unittests 89.28% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Elements/ElementFeatures.php 90.47% <0.00%> (-1.02%) ⬇️
src/Model/FeatureObject.php 85.71% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0eabbd...ffb7937. Read the comment docs.

@jsirish jsirish merged commit 3b1d8ba into dynamic:master Jul 8, 2022
@jsirish jsirish deleted the refactor/devRequirements branch July 8, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant