Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementFeatures $owns Features #10

Merged
merged 2 commits into from
Jun 1, 2019

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Jun 1, 2019

per expected SS4 behavior

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage     92.15%   92.15%           
  Complexity       11       11           
=========================================
  Files             2        2           
  Lines            51       51           
=========================================
  Hits             47       47           
  Misses            4        4
Flag Coverage Δ Complexity Δ
#php 92.15% <ø> (ø) 11 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementFeatures.php 89.47% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f43395...104bd56. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage     92.15%   92.15%           
  Complexity       11       11           
=========================================
  Files             2        2           
  Lines            51       51           
=========================================
  Hits             47       47           
  Misses            4        4
Flag Coverage Δ Complexity Δ
#php 92.15% <ø> (ø) 11 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/Elements/ElementFeatures.php 89.47% <ø> (ø) 7 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f43395...104bd56. Read the comment docs.

@jsirish jsirish merged commit 0086cc7 into dynamic:master Jun 1, 2019
@jsirish jsirish deleted the feature/ownsFeatures branch June 1, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant