Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ante): allow doing vesting txs based on whitelist #216

Merged
merged 37 commits into from
May 9, 2024
Merged

feat(ante): allow doing vesting txs based on whitelist #216

merged 37 commits into from
May 9, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Apr 29, 2024 •
edited
Loading

Description

Closes #193

Related #169

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@danwt danwt mentioned this pull request Apr 29, 2024
Closed
29 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 29, 2024
View reviewed changes
app/ante/handlers.go Fixed Show fixed Hide fixed
@danwt danwt marked this pull request as ready for review April 29, 2024 14:35
@danwt danwt changed the title feat(ante): allow performing vesting txs based on whitelist feat(ante): allow doing vesting txs based on whitelist Apr 29, 2024
@danwt
Copy link
Contributor Author

danwt commented Apr 29, 2024

tested locally 👍

@danwt danwt self-assigned this Apr 30, 2024
@danwt danwt requested a review from zale144 May 1, 2024 13:23
@danwt danwt mentioned this pull request May 7, 2024
Closed
mtsitrin
mtsitrin requested changes May 7, 2024
View reviewed changes
app/ante/ante.go Outdated Show resolved Hide resolved
app/ante/handlers.go Outdated Show resolved Hide resolved
app/ante/handlers.go Outdated Show resolved Hide resolved
app/ante/handlers.go Outdated Show resolved Hide resolved
@danwt danwt requested a review from mtsitrin May 9, 2024 10:32
mtsitrin
mtsitrin previously approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@mtsitrin mtsitrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@omritoptix omritoptix changed the base branch from release/v2.1.x to main May 9, 2024 12:49
@omritoptix omritoptix dismissed mtsitrin’s stale review May 9, 2024 12:49

The base branch was changed.

@omritoptix omritoptix merged commit e1c968f into main May 9, 2024
54 of 56 checks passed
@omritoptix omritoptix deleted the danwt/193-use-native-ante-handler-and-permissioned-vesting-ante-handler-v2.1.x-compat-2 branch May 9, 2024 14:04
omritoptix pushed a commit that referenced this pull request May 15, 2024
@danwt @omritoptix
feat(ante): allow doing vesting txs based on whitelist (#216)
0eb94fc 
Co-authored-by: bcdev.tools <153984575+0xbcdev@users.noreply.github.com>
(cherry picked from commit e1c968f)
omritoptix pushed a commit that referenced this pull request May 15, 2024
@danwt @omritoptix
feat(ante): allow doing vesting txs based on whitelist (#216)
52cb0c5 
Co-authored-by: bcdev.tools <153984575+0xbcdev@users.noreply.github.com>
(cherry picked from commit e1c968f)
omritoptix pushed a commit that referenced this pull request May 31, 2024
@danwt @omritoptix
feat(ante): allow doing vesting txs based on whitelist (#216)
4353232 
Co-authored-by: bcdev.tools <153984575+0xbcdev@users.noreply.github.com>
(cherry picked from commit e1c968f)
omritoptix pushed a commit that referenced this pull request May 31, 2024
@danwt @omritoptix
feat(ante): allow doing vesting txs based on whitelist (#216)
1ddefe0 
Co-authored-by: bcdev.tools <153984575+0xbcdev@users.noreply.github.com>
(cherry picked from commit e1c968f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

@mtsitrin mtsitrin mtsitrin left review comments

@zale144 zale144 Awaiting requested review from zale144

Assignees

@danwt danwt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use native ante handler and permissioned vesting
4 participants
@danwt @omritoptix @mtsitrin @0xbcdev