ci: update workflows and template (#111)

.github/pull_request_template.md

@@ -0,0 +1,61 @@
+## Description
+
+<!-- Add a description of the changes that this PR introduces and the files that
+are the most critical to review.
+-->
+
+----
+
+Closes #XXX
+
+**All** items are required. Please add a note to the item if the item is not applicable and
+please add links to any relevant follow-up issues.
+
+PR review checkboxes:
+
+I have...
+
+- [ ]  Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
+- [ ]  Targeted PR against the correct branch
+- [ ]  included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
+- [ ]  Linked to the GitHub issue with discussion and accepted design
+- [ ]  Targets only one GitHub issue
+- [ ]  Wrote unit and integration tests
+- [ ]  Wrote relevant migration scripts if necessary
+- [ ]  All CI checks have passed
+- [ ]  Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code)
+- [ ]  Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
+- [ ]  Add an issue in the [e2e-tests repo](https://github.com/dymensionxyz/e2e-tests) if necessary
+
+SDK Checklist
+- [ ] Import/Export Genesis
+- [ ] Registered Invariants
+- [ ] Registered Events
+- [ ] Updated openapi.yaml
+- [ ] No usage of go `map`
+- [ ] No usage of `time.Now()`
+- [ ] Used fixed point arithmetic and not float arithmetic
+- [ ] Avoid panicking in Begin/End block as much as possible
+- [ ] No unexpected math Overflow
+- [ ] Used `sendCoin` and not `SendCoins`
+- [ ] Out-of-block compute is bounded
+- [ ] No serialized ID at the end of store keys
+- [ ] UInt to byte conversion should use BigEndian
+
+Full security checklist [here](https://www.faulttolerant.xyz/2024-01-16-cosmos-security-1/)
+
+
+----;
+
+For Reviewer:
+
+- [ ]  Confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
+- [ ]  Reviewers assigned
+- [ ]  Confirmed all author checklist items have been addressed
+
+---;
+
+After reviewer approval:
+
+- [ ]  In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
+- [ ]  In case the PR targets a release branch, PR must be rebased.

.github/workflows/codeql.yml

@@ -0,0 +1,41 @@
+name: "CodeQL"
+
+on:
+  pull_request:
+    paths:
+      - "**.go"
+  push:
+    # The branches below must be a subset of the branches above
+    branches:
+      - main
+      - release/**
+    paths:
+      - "**.go"
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v3
+      - uses: actions/setup-go@v3
+        with:
+          go-version: "1.22"
+      # Initializes the CodeQL tools for scanning.
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          languages: "go"
+          queries: crypto-com/cosmos-sdk-codeql@main,security-and-quality
+
+      - name: Build
+        run: make build
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2

.github/workflows/golangci_lint.yml

@@ -0,0 +1,23 @@
+name: golangci-lint
+on:
+  push:
+    tags:
+      - v*
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  golangci:
+    name: golangci-lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          go-version: "1.22"
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v4.0.0
+        with:
+          version: v1.56.2
+          skip-cache: true

.github/workflows/markdown_lint.yml

@@ -0,0 +1,19 @@
+name: markdown-lint
+on:
+  push:
+    tags:
+      - v*
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  markdownlint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: markdownlint-cli
+        uses: nosborn/github-action-markdown-cli@v3.2.0
+        with:
+          files: ./
+          config_file: .markdownlint.yaml

.markdownlint.yaml

@@ -0,0 +1,7 @@
+default: true
+MD010:
+  code_blocks: false
+MD013: false
+MD024: true
+MD033:
+  allowed_elements: ["img"]

README.md

@@ -1,6 +1,6 @@
-<h1 align="center">Dymension EVM Rollapp</h1>
+# Dymension EVM Rollapp
 
-# Rollapp-evm - A template EVM RollApp chain
+## Rollapp-evm - A template EVM RollApp chain
 
 This repository hosts `rollapp-evm`, a template implementation of a dymension rollapp with `EVM` execution layer.
 
@@ -12,7 +12,7 @@ It uses Cosmos-SDK's [simapp](https://github.com/cosmos/cosmos-sdk/tree/main/sim
 - wired with EVM and ERC20 modules by [Evmos](https://github.com/evmos/evmos)
 - wired IBC for [ICS 20 Fungible Token Transfers](https://github.com/cosmos/ibc/tree/main/spec/app/ics-020-fungible-token-transfer)
 - Uses `dymint` for block sequencing and replacing `tendermint`
-- Uses modules from `dymension-RDK` to sync with `dymint` and provide RollApp custom logic 
+- Uses modules from `dymension-RDK` to sync with `dymint` and provide RollApp custom logic
 
 ## Overview
 

app/ante.go

@@ -1,6 +1,7 @@
 package app
 
 import (
+	errorsmod "cosmossdk.io/errors"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
 	"github.com/cosmos/cosmos-sdk/x/auth/ante"
@@ -51,15 +52,15 @@ func GetAnteDecorators(options HandlerOptions) []sdk.AnteDecorator {
 func NewAnteHandler(options HandlerOptions) (sdk.AnteHandler, error) {
 	//From x/auth/ante.go
 	if options.AccountKeeper == nil {
-		return nil, sdkerrors.Wrap(sdkerrors.ErrLogic, "account keeper is required for ante builder")
+		return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "account keeper is required for ante builder")
 	}
 
 	if options.BankKeeper == nil {
-		return nil, sdkerrors.Wrap(sdkerrors.ErrLogic, "bank keeper is required for ante builder")
+		return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "bank keeper is required for ante builder")
 	}
 
 	if options.SignModeHandler == nil {
-		return nil, sdkerrors.Wrap(sdkerrors.ErrLogic, "sign mode handler is required for ante builder")
+		return nil, errorsmod.Wrap(sdkerrors.ErrLogic, "sign mode handler is required for ante builder")
 	}
 
 	return sdk.ChainAnteDecorators(GetAnteDecorators(options)...), nil