Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(code standards): remove misleading part of log message upon app hash mismatch #928

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix(code standards): remove misleading part of log message upon app hash mismatch #928

merged 1 commit into from
Jun 24, 2024

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Jun 24, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #917

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@zale144 zale144 self-assigned this Jun 24, 2024
@zale144 zale144 requested a review from a team as a code owner June 24, 2024 15:21
@omritoptix omritoptix merged commit 10068f8 into main Jun 24, 2024
7 checks passed
@omritoptix omritoptix deleted the zale144/917-someone-is-behaving-badly branch June 24, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemijspavlovs artemijspavlovs artemijspavlovs approved these changes

@omritoptix omritoptix omritoptix approved these changes

Assignees

@zale144 zale144

Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misleading log
3 participants
@zale144 @omritoptix @artemijspavlovs