Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(block manage): reducing batch overhead size when reaping Txs from mempool #886

Merged
merged 4 commits into from
Jun 3, 2024
Merged

fix(block manage): reducing batch overhead size when reaping Txs from mempool #886

merged 4 commits into from
Jun 3, 2024

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #885

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin linked an issue May 27, 2024 that may be closed by this pull request
Commit size + Block size could be greater than batch size #885
Closed
omritoptix
omritoptix reviewed May 28, 2024
View reviewed changes
block/types.go Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 28, 2024
View reviewed changes
block/produce.go Fixed Show fixed Hide fixed
@mtsitrin mtsitrin marked this pull request as ready for review May 28, 2024 12:08
@mtsitrin mtsitrin requested a review from a team as a code owner May 28, 2024 12:08
danwt
danwt requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works

I left some readability requests

BTW

Maybe instead of using a threshold like 90%

We can just binary search until we get something that makes maximum use of the space without overfilling. (Using a good start point to note be wasteful)

block/produce.go Outdated Show resolved Hide resolved
block/submit_test.go Show resolved Hide resolved
block/submit_test.go Outdated Show resolved Hide resolved
block/submit_test.go Outdated Show resolved Hide resolved
block/submit_test.go Outdated Show resolved Hide resolved
block/submit_test.go Outdated Show resolved Hide resolved
block/submit_test.go Outdated Show resolved Hide resolved
block/submit_test.go Show resolved Hide resolved
block/submit_test.go Show resolved Hide resolved
block/submit_test.go Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 2, 2024
View reviewed changes
block/produce.go Dismissed Show dismissed Hide dismissed
@mtsitrin mtsitrin requested review from danwt and omritoptix June 2, 2024 07:57
danwt
danwt approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@omritoptix omritoptix merged commit 5ff49c7 into main Jun 3, 2024
6 checks passed
@omritoptix omritoptix deleted the mtsitrin/885-commit-size-+-block-size-could-be-greater-than-batch-size branch June 3, 2024 11:59
omritoptix pushed a commit that referenced this pull request Jun 3, 2024
@mtsitrin @omritoptix
fix(block manage): reducing batch overhead size when reaping Txs from…
edf99d7 
… mempool (#886)
omritoptix pushed a commit that referenced this pull request Jun 3, 2024
@mtsitrin @omritoptix
fix(block manage): reducing batch overhead size when reaping Txs from…
8db0572 
… mempool (#886)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwt danwt danwt approved these changes

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commit size + Block size could be greater than batch size
3 participants
@mtsitrin @omritoptix @danwt