refactor(settlement): settlement layer redundent abstraction layer #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
changed the title
danwt
requested changes
May 21, 2024
There was a problem hiding this comment.
Great change! I think you removed one entire layer of indirection right? Awesome
I suggest a change to make things cleaner and more idiomatic
Please change
- settlement.LayerI to settlement.Client
- dymension.LayerClient to dymension.Client
- grpc.LayerClient to grpc.Client
- local.LocalClient to local.Client
and change all receiver to c
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if err != nil { | ||
| return err | ||
| } | ||
| go d.eventHandler() | ||
| go c.eventHandler() |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
mtsitrin
deleted the
mtsitrin/629-refactor-settlement-layer-redundent-abstraction-layer
branch
omritoptix
pushed a commit
that referenced
this pull request
Jun 3, 2024
omritoptix
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayerIandHubClientinterfaces in the settlement packagethere was almost zero common code for
basestruct, while it created 2 almost identical intrefaces.on the dymension package, with the cosmosClient we had 3(!) interfaces doing basically the same
PR Standards
Opening a pull request should be able to meet the following requirements
Close #629
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: