Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(p2p): improving logs #872

Merged
merged 2 commits into from
May 16, 2024
Merged

feat(p2p): improving logs #872

merged 2 commits into from
May 16, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented May 16, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

Close #800

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner May 16, 2024 11:39
@srene srene self-assigned this May 16, 2024
@mtsitrin mtsitrin merged commit c8d116e into main May 16, 2024
6 checks passed
@mtsitrin mtsitrin deleted the srene/800-improve-p2p-logs branch May 16, 2024 12:05
omritoptix pushed a commit that referenced this pull request May 18, 2024
@srene @omritoptix
feat(p2p): improving logs (#872)
9cd6455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwt danwt danwt approved these changes

Assignees

@srene srene

Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve p2p logging
3 participants
@srene @danwt @mtsitrin