-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(p2p): refactor p2p config options #861
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
==========================================
- Coverage 40.44% 39.65% -0.80%
==========================================
Files 120 118 -2
Lines 18935 18703 -232
==========================================
- Hits 7659 7416 -243
- Misses 10201 10232 +31
+ Partials 1075 1055 -20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a better name for BootstrapTime
Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com>
23a92c0
to
3603b27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gj
Co-authored-by: Daniel T <30197399+danwt@users.noreply.github.com>
PR Standards
All p2p config parameters have been moved to P2P to specific paramaters, to avoid confusion with Tendermint p2p options
Opening a pull request should be able to meet the following requirements
Close #797
<-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: