Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set sequencer mode by hub and not by a flag #821

Merged
merged 2 commits into from
May 12, 2024
Merged

feat: set sequencer mode by hub and not by a flag #821

merged 2 commits into from
May 12, 2024

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented May 8, 2024 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

Close #283

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin linked an issue May 8, 2024 that may be closed by this pull request
set sequencer mode by hub and not by a flag #283
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems May 8, 2024
View reviewed changes
node/node.go Dismissed Show dismissed Hide dismissed
node/node.go Dismissed Show dismissed Hide dismissed
@mtsitrin mtsitrin marked this pull request as ready for review May 8, 2024 10:16
@mtsitrin mtsitrin requested a review from a team as a code owner May 8, 2024 10:16
@mtsitrin mtsitrin self-assigned this May 8, 2024
@mtsitrin mtsitrin requested review from srene and danwt May 8, 2024 12:55
@danwt
Copy link
Contributor

danwt commented May 8, 2024

Is there an issue?

danwt
danwt approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
maybe in a followup pr we can replace 'aggregator' everywhere with 'sequencer'
Would it be valid?
thanks

@mtsitrin mtsitrin merged commit 5848812 into main May 12, 2024
5 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/283-set-sequencer-mode-by-hub-and-not-by-a-flag branch May 12, 2024 06:09
omritoptix pushed a commit that referenced this pull request May 18, 2024
@mtsitrin @omritoptix
feat: set sequencer mode by hub and not by a flag (#821)
11bbc79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwt danwt danwt approved these changes

@srene srene Awaiting requested review from srene

Assignees

@mtsitrin mtsitrin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set sequencer mode by hub and not by a flag
2 participants
@mtsitrin @danwt