Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce config rollapp id to be same as genesis chain id #697

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Enforce config rollapp id to be same as genesis chain id #697

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31f5998
Enforce settlement config rollapp id to be same as chain id from the …
zale144 Apr 16, 2024
6188b9b
Fix tests
zale144 Apr 16, 2024
cbb4fcb
Fix tests again
zale144 Apr 16, 2024
efa37ee
Fix tests once again
zale144 Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests once again
  • Loading branch information
@zale144
zale144 committed Apr 16, 2024
commit efa37eeb87156e13b82d8c13ba65524b4b42f2b7
15 changes: 14 additions & 1 deletion rpc/json/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ func getRPC(t *testing.T) (*mocks.Application, *client.Client) {
signingKey, proposerPubKey, _ := crypto.GenerateEd25519Key(rand.Reader)
proposerPubKeyBytes, err := proposerPubKey.Raw()
require.NoError(err)

rollappID := "rollapp_1234-1"

config := config.NodeConfig{
Aggregator: true, DALayer: "mock", SettlementLayer: "mock",
BlockManagerConfig: config.BlockManagerConfig{
Expand All @@ -308,9 +311,19 @@ func getRPC(t *testing.T) (*mocks.Application, *client.Client) {
},
SettlementConfig: settlement.Config{
ProposerPubKey: hex.EncodeToString(proposerPubKeyBytes),
RollappID: rollappID,
},
}
node, err := node.NewNode(context.Background(), config, key, signingKey, proxy.NewLocalClientCreator(app), &types.GenesisDoc{ChainID: "test"}, log.TestingLogger(), mempool.NopMetrics())
node, err := node.NewNode(
context.Background(),
config,
key,
signingKey,
proxy.NewLocalClientCreator(app),
&types.GenesisDoc{ChainID: rollappID},
log.TestingLogger(),
mempool.NopMetrics(),
)
require.NoError(err)
require.NotNil(node)

Expand Down
Loading