Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: revert passing operator address on InitChain #617

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner March 25, 2024 21:07
@mtsitrin mtsitrin linked an issue Mar 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.09%. Comparing base (d70f556) to head (2dc783a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   44.16%   44.09%   -0.08%     
==========================================
  Files         119      119              
  Lines       16474    16414      -60     
==========================================
- Hits         7276     7237      -39     
+ Misses       8170     8156      -14     
+ Partials     1028     1021       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin self-assigned this Mar 26, 2024
@omritoptix omritoptix merged commit 19f8877 into main Mar 26, 2024
6 checks passed
@omritoptix omritoptix deleted the 615-cant-decode-ethsecp2561k-as-proposer-app-key branch March 26, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't decode ethsecp2561k as proposer app key
2 participants