Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add metrics provider as a paramater upon node creation #598

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

artemijspavlovs
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@artemijspavlovs artemijspavlovs requested a review from a team as a code owner March 5, 2024 06:38
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.15%. Comparing base (da7f62c) to head (2bd6a04).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   46.14%   46.15%           
=======================================
  Files         101      101           
  Lines       15641    15643    +2     
=======================================
+ Hits         7218     7220    +2     
  Misses       7404     7404           
  Partials     1019     1019           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix merged commit da9a85b into main Mar 5, 2024
5 checks passed
@omritoptix omritoptix deleted the artemijspavlovs/add-prometheus-metrics-rovider branch March 5, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants