chore: halt production incase of production error #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=======================================
Coverage 52.44% 52.44%
=======================================
Files 100 100
Lines 14685 14686 +1
=======================================
+ Hits 7701 7702 +1
Misses 5879 5879
Partials 1105 1105 ☔ View full report in Codecov by Sentry. |
ItayLevyOfficial
approved these changes
Nov 15, 2023
| @@ -93,6 +93,7 @@ func (m *Manager) ProduceBlockLoop(ctx context.Context) { | |||
| } | |||
| if err != nil { | |||
| m.logger.Error("error while producing block", "error", err) | |||
| m.shouldProduceBlocksCh <- false | |||
There was a problem hiding this comment.
Will it also change the status to "unhealthy"? Or will it crash the sequencer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: