-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tendermint headers compatibility #505
Conversation
tmCommit := tmtypes.Commit{ | ||
Height: int64(commit.Height), | ||
Round: 0, | ||
BlockID: tmtypes.BlockID{ | ||
Hash: commit.HeaderHash[:], | ||
Hash: headerHash[:], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why u need the commit *types.Commit
argument? seems u take everything from the header itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line for example if len(commit.TMSignature.Signature) == 0 {
is using the commit
field and can't use the header field.
Codecov Report
@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 52.33% 52.44% +0.11%
==========================================
Files 100 100
Lines 14565 14685 +120
==========================================
+ Hits 7622 7701 +79
- Misses 5850 5879 +29
- Partials 1093 1105 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: