Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tendermint headers compatibility #505

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

omritoptix
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix linked an issue Oct 10, 2023 that may be closed by this pull request
tmCommit := tmtypes.Commit{
Height: int64(commit.Height),
Round: 0,
BlockID: tmtypes.BlockID{
Hash: commit.HeaderHash[:],
Hash: headerHash[:],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why u need the commit *types.Commit argument? seems u take everything from the header itself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line for example if len(commit.TMSignature.Signature) == 0 { is using the commit field and can't use the header field.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #505 (059fd6d) into main (ddcbc64) will increase coverage by 0.11%.
The diff coverage is 67.91%.

@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   52.33%   52.44%   +0.11%     
==========================================
  Files         100      100              
  Lines       14565    14685     +120     
==========================================
+ Hits         7622     7701      +79     
- Misses       5850     5879      +29     
- Partials     1093     1105      +12     
Files Coverage Δ
block/manager.go 62.33% <ø> (ø)
block/testutil.go 65.62% <ø> (ø)
conv/abci/block.go 97.47% <100.00%> (+0.13%) ⬆️
types/serialization.go 72.52% <100.00%> (+1.28%) ⬆️
block/produce.go 80.32% <74.46%> (-2.03%) ⬇️
types/pb/dymint/dymint.pb.go 40.90% <43.63%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@omritoptix omritoptix marked this pull request as ready for review October 18, 2023 14:13
@omritoptix omritoptix requested a review from a team as a code owner October 18, 2023 14:13
@omritoptix omritoptix merged commit ec633de into main Oct 19, 2023
5 checks passed
@omritoptix omritoptix deleted the omritoptix/374-tm-headers-compatibility branch October 19, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tendermint-like headers for tooling compatiblity
2 participants