Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduced empty blocks submission #452

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

mtsitrin
Copy link
Contributor

  • emptyBlocks timer can be set higher than block submission timeout
  • block submission in separate loop, trigger by timer.
    will send batch after BatchSubmitMaxTime if blocks exists

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner August 23, 2023 17:58
omritoptix
omritoptix previously approved these changes Aug 23, 2023
@mtsitrin mtsitrin merged commit 2e9bb1d into main Aug 23, 2023
@mtsitrin mtsitrin deleted the hotfix/reduced_empty_blocks_submission branch August 23, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants