Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update rollapp proto to the current dymension main #1161

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Oct 22, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@zale144 zale144 self-assigned this Oct 22, 2024
@zale144 zale144 requested a review from a team as a code owner October 22, 2024 15:05
Copy link
Contributor

@keruch keruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same comment as here dymensionxyz/dymension#1341 (comment)

@zale144 zale144 closed this Oct 23, 2024
@zale144 zale144 reopened this Oct 23, 2024
omritoptix
omritoptix previously approved these changes Oct 24, 2024
@omritoptix
Copy link
Contributor

@zale144 build failed

@omritoptix omritoptix dismissed their stale review October 24, 2024 14:27

build failed

@mtsitrin mtsitrin merged commit 3a38fb3 into main Oct 25, 2024
6 checks passed
@mtsitrin mtsitrin deleted the zale144/update-rollapp-proto branch October 25, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants